Skip to content

🐛 Fix Celery's Redis backend SSL config #7407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2025
Merged

🐛 Fix Celery's Redis backend SSL config #7407

merged 6 commits into from
Mar 25, 2025

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 21, 2025 •
edited by sanderegg
Loading

What do these changes do?

Celery contains its own Redis client and cert_reqs need to be explicitly disabled (ssl.CERT_NONE).

The sto-worker service was not able to start, raising the following error:

A rediss:// URL must have parameter ssl_cert_reqs and this must be set to 
CERT_REQUIRED, CERT_OPTIONAL, or CERT_NONE

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Mar 21, 2025
@giancarloromeo giancarloromeo marked this pull request as ready for review March 21, 2025 12:48
bisgaard-itis
bisgaard-itis approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks for the quick fix

@codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (4a3c8fe) to head (ab3bd04).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4a3c8fe) and HEAD (ab3bd04). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (4a3c8fe) HEAD (ab3bd04)
unittests 27 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7407       +/-   ##
===========================================
- Coverage   86.00%   68.71%   -17.30%     
===========================================
  Files        1638      725      -913     
  Lines       63240    34321    -28919     
  Branches     1131      168      -963     
===========================================
- Hits        54390    23582    -30808     
- Misses       8528    10681     +2153     
+ Partials      322       58      -264
Flag Coverage Δ
integrationtests 65.17% <ø> (-0.01%) ⬇️
unittests 84.80% <100.00%> (-1.99%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.55% <ø> (+0.02%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 84.80% <100.00%> (∅)
webclient ∅ <ø> (∅)
webserver 59.14% <ø> (-26.60%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3c8fe...ab3bd04. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

odeimaiz
odeimaiz approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

sanderegg
sanderegg approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 21, 2025
@giancarloromeo giancarloromeo enabled auto-merge (squash) March 21, 2025 13:19
@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 21, 2025
pcrespov
pcrespov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg disabled auto-merge March 25, 2025 10:50
@sanderegg sanderegg merged commit b453ddc into ITISFoundation:master Mar 25, 2025
3 of 4 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo deleted the fix-redis-backend-cert-reqs branch March 25, 2025 11:18
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@giancarloromeo @odeimaiz @mrnicegyu11
🐛 Fix Celery's Redis backend SSL config (ITISFoundation#7407)
dbda77f 
Co-authored-by: Odei Maiz <[email protected]>
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg sanderegg approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@giancarloromeo giancarloromeo

Labels

🤖-automerge marks PR as ready to be merged for Mergify

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

7 participants

@giancarloromeo @GitHK @pcrespov @odeimaiz @sanderegg @YuryHrytsuk @bisgaard-itis